Skip to content

[#408] Create tag component #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 20, 2025
Merged

[#408] Create tag component #49

merged 10 commits into from
Aug 20, 2025

Conversation

ludovic35
Copy link
Member

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Orange-OpenSource/ouds-ios#408

Description

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I checked I am using the last version of OUDS iOS library
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibility review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@ludovic35 ludovic35 requested a review from pylapp as a code owner August 11, 2025 15:02
@ludovic35 ludovic35 changed the title 408 component create component tags [#408] Create tag component Aug 11, 2025
@pylapp pylapp self-assigned this Aug 19, 2025
@pylapp pylapp force-pushed the 408-component-create-component---tags branch from eb21ee0 to 6516383 Compare August 20, 2025 08:43
@pylapp pylapp merged commit 8d9ed92 into develop Aug 20, 2025
14 of 15 checks passed
@pylapp pylapp deleted the 408-component-create-component---tags branch August 20, 2025 14:06
pylapp added a commit that referenced this pull request Aug 20, 2025
@ludovic35 @pylapp
feat: add tag component (Orange-OpenSource/ouds-ios#408) (#49)
6fc7584 
Add OUDSTag component and tests

Reviewed-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Ludovic Pinel <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pylapp pylapp Awaiting requested review from pylapp pylapp is a code owner

Assignees

@pylapp pylapp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludovic35 @pylapp